Skip to content

perf(propagate): don't increase the stack when there is only one subscriber #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

perf(propagate): don't increase the stack when there is only one subscriber #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions src/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,12 @@ function linkNewDep(dep: Dependency, sub: Subscriber, nextDep: Link | undefined,

export function propagate(subs: Link): void {
let targetFlag = SubscriberFlags.Dirty;
let link = subs;
let stack = 0;
let nextSub: Link | undefined;

top: do {
const sub = subs.sub;
const sub = link.sub;
const subFlags = sub.flags;

if (!(subFlags & SubscriberFlags.Tracking)) {
Expand All @@ -145,14 +146,17 @@ export function propagate(subs: Link): void {
if ('subs' in sub) {
const subSubs = sub.subs;
if (subSubs !== undefined) {
sub.depsTail!.nextDep = subs;
subs = subSubs;
if ('notify' in sub) {
targetFlag = SubscriberFlags.RunInnerEffects;
} else {
if (subSubs.nextSub !== undefined) {
sub.depsTail!.nextDep = subs;
link = subs = subSubs;
++stack;
targetFlag = SubscriberFlags.ToCheckDirty;
} else {
link = subSubs;
targetFlag = 'notify' in sub
? SubscriberFlags.RunInnerEffects
: SubscriberFlags.ToCheckDirty;
}
++stack;
continue;
}
}
Expand All @@ -165,21 +169,24 @@ export function propagate(subs: Link): void {
queuedEffectsTail = sub;
}
}
} else if (isValidLink(subs, sub)) {
} else if (isValidLink(link, sub)) {
sub.flags |= targetFlag;
if (!(subFlags >> 2)) {
sub.flags |= SubscriberFlags.CanPropagate;
if ('subs' in sub) {
const subSubs = sub.subs;
if (subSubs !== undefined) {
sub.depsTail!.nextDep = subs;
subs = subSubs;
if ('notify' in sub) {
targetFlag = SubscriberFlags.RunInnerEffects;
} else {
if (subSubs.nextSub !== undefined) {
sub.depsTail!.nextDep = subs;
link = subs = subSubs;
++stack;
targetFlag = SubscriberFlags.ToCheckDirty;
} else {
link = subSubs;
targetFlag = 'notify' in sub
? SubscriberFlags.RunInnerEffects
: SubscriberFlags.ToCheckDirty;
}
++stack;
continue;
}
}
Expand All @@ -194,22 +201,27 @@ export function propagate(subs: Link): void {
const depsTail = dep.depsTail!;
const prevLink = depsTail.nextDep!;
depsTail.nextDep = undefined;
subs = prevLink.nextSub!;

link = subs = prevLink.nextSub!;
if (subs !== undefined) {
if (!stack) {
targetFlag = SubscriberFlags.Dirty;
} else {
targetFlag = SubscriberFlags.ToCheckDirty;
}
targetFlag = stack
? SubscriberFlags.ToCheckDirty
: SubscriberFlags.Dirty;
continue top;
}
dep = prevLink.dep as Subscriber;
} while (stack);
}
break;
}
subs = nextSub;
if (link !== subs) {
const dep = subs.dep;
targetFlag = 'update' in dep
? SubscriberFlags.ToCheckDirty
: 'notify' in dep
? SubscriberFlags.RunInnerEffects
: SubscriberFlags.Dirty;
}
link = subs = nextSub;
} while (true);

if (!batchDepth) {
Expand Down
Loading