Hotfix: use node fs-extra to handle copying and removing files #3hk00xt #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacktivist123
changed the title
|
Task linked: CU-3hk00xt |
seancdavis
requested changes
Oct 25, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import chalk from 'chalk'; | |||
| import { exec } from 'child_process'; | |||
| import fs from 'fs'; | |||
| import fs from 'fs-extra'; | |||
There was a problem hiding this comment.
If you're going to use a package, it should be listed as a dependency in package.json. Although widely used, it's not safe to rely on dependencies' dependencies.
There was a problem hiding this comment.
I'd also like to know why this is necessary beyond the fs basics? It doesn't seem like we're doing anything fancy, and I like to keep dependencies to a minimum.
There was a problem hiding this comment.
It's because of the move and remove functions, there are some underlying issues especially with callbacks that fs has but fs-extra solves it.
hacktivist123
commented
Oct 25, 2022
seancdavis
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue stackbit-themes/stackbit-examples#17. It introduces node fs-extra to handle the following:
Copying files on all OS types
Removing files on all OS types
Remove code where we are running commands directly
Increase performance a bit