Skip to content

fix: Construction of OIDC endpoint when rootPath has a trailing slash #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 22, 2024

Description

Part of stackabletech/operator-rs#910

Before this PR the operator generated
http-server.authentication.oauth2.issuer=https\://185.56.150.115\:30584/realms/demo/
resulting in
java.lang.IllegalStateException: Invalid response from OpenID Metadata endpoint. The value of the "issuer" claim in Metadata document different than the Issuer URL used for the Configuration Request.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer
Copy link
Member Author

@sbernauer sbernauer changed the title fix: Calculation of OIDC endpoint when rootPath has a trailing slash fix: Construction of OIDC endpoint when rootPath has a trailing slash Nov 25, 2024
@sbernauer sbernauer enabled auto-merge November 25, 2024 10:20
@sbernauer sbernauer added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 85490fa Nov 25, 2024
16 of 17 checks passed
@sbernauer sbernauer deleted the fix/oidc-endpoint-calculation branch November 25, 2024 10:27
@lfrancke
Copy link
Member

lfrancke commented Dec 4, 2024

Did this make it into 24.11?

@sbernauer
Copy link
Member Author

Nope, but it will be part of 24.11.1. Not sure what label we should use here ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants