Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented May 25, 2022

Description

See https://docs.stackable.tech/home/contributor/adr/ADR019-trino_catalog_definitions.html and https://docs.stackable.tech/home/contributor/adr/ADR020-trino_catalog_usage.html

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from soenkeliebau May 25, 2022 15:30
@nightkr nightkr self-assigned this May 25, 2022
@nightkr
Copy link
Contributor Author

nightkr commented May 25, 2022

There's still some work to be done cleaning this up and migrating the existing S3 support (which is currently broken).

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just writing some things down, I don't expect you @teozkr to do anything as probably someone else will pick up this PR

@sbernauer sbernauer self-assigned this Aug 3, 2022
@sbernauer sbernauer force-pushed the feature/trino-catalog branch from 7b67227 to 051746f Compare August 3, 2022 13:42
@sbernauer sbernauer marked this pull request as ready for review August 3, 2022 14:14
@fhennig
Copy link
Contributor

fhennig commented Aug 22, 2022

is this for #13 ?

@sbernauer
Copy link
Member

Yeah, my thought process was to do them at once, yes.
I' currently having fun with merge conflicts from 97d6a6e

@sbernauer
Copy link
Member

Superseded by #263

@sbernauer sbernauer closed this Aug 25, 2022
@sbernauer sbernauer deleted the feature/trino-catalog branch April 27, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants