Skip to content

feat: Release candidates #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jan 23, 2025
Merged

feat: Release candidates #95

merged 37 commits into from
Jan 23, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 2, 2024 •
edited
Loading

Fixes: #82
Fixes: #81

@adwk67 adwk67 changed the title combine bugfix script with release-tag scripts; wip - release candidates feat: Release candidates Dec 2, 2024
@adwk67 adwk67 mentioned this pull request Dec 5, 2024
Merged
@adwk67 adwk67 marked this pull request as ready for review December 13, 2024 15:49
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jan 15, 2025
Closed
NickLarsenNZ
NickLarsenNZ reviewed Jan 22, 2025
View reviewed changes
Techassi
Techassi reviewed Jan 22, 2025
View reviewed changes
Techassi
Techassi reviewed Jan 22, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just left a few suggestions.

adwk67 and others added 2 commits January 22, 2025 13:59
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
7f60a54 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
6d8ef4b 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
adwk67 and others added 11 commits January 22, 2025 14:00
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
408901a 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
a872eab 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
405bc13 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
6ca2de0 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/create-release-candidate-branch.sh
9baecf7 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/README.md
7144302 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/README.md
a6db39f 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update release/README.md
73dfd37 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67
review changes
81a0aa9
@adwk67
review feedback: global git user and prompt
e3f1764
@adwk67
include email in git user check
5ec621c
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 enabled auto-merge January 23, 2025 08:40
Techassi
Techassi reviewed Jan 23, 2025
View reviewed changes
adwk67 and others added 2 commits January 23, 2025 10:26
@adwk67 @Techassi
Update release/README.md
e516821 
Co-authored-by: Techassi <git@techassi.dev>
@adwk67 @Techassi
Update release/README.md
334b7d1 
Co-authored-by: Techassi <git@techassi.dev>
@adwk67 adwk67 self-assigned this Jan 23, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 513be31 Jan 23, 2025
1 check passed
@adwk67 adwk67 deleted the feature/release-candidates branch January 23, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@adwk67 adwk67

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend release scripts to enable release candidates Modify the release process to avoid branch protection errors
3 participants
@adwk67 @NickLarsenNZ @Techassi