-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Remove hardcoded uid and gid #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c945f0
to
eaffcd2
Compare
eaffcd2
to
02ff8d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
OKD test suite running here https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/25/
Thanks! I've removed the PR from the merge queue until the test succeeds |
Problems on OpenShift:
The history STS is not created because:
|
Thanks. This probably means all others are broken too. I don't have time today but I'll try to take a look tomorrow. |
Unrelated but I thought I'd fix here f04723b Fixes:
|
You'd think but ... superset worked. |
I keep forgetting that So actually, if installed properly and with the fix from above it should work. https://testing.stackable.tech/job/spark-k8s-operator-it-custom/26/ |
Update: same on OCP 4.17 Tests look better but on OpenShift 4.18, this
fails to create the driver with the message:
Cannot tell what the problem is and why only this particular test is affected. |
Thanks. I have more work to do. I'll look at it when I'm back. |
Update: 30f8f2b The commit above fixes the last two remaining tests. Tested with OCP 4.17
Note The image I will make a separate PR to publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now
Description
Part of stackabletech/issues#651
Remove hardcoded uid and gid, they'll default to the ones from the docker images now.
For 25.7 that means they might change from 1000/0
See stackabletech/docker-images#916 for details
Definition of Done Checklist
Author
Reviewer
Acceptance