Skip to content

Let secret-operator handle PKCS#12 conversion #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2023
Merged

Let secret-operator handle PKCS#12 conversion #286

merged 3 commits into from
Sep 27, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 26, 2023 •
edited by razvan
Loading

Description

fixes #282

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@maltesander maltesander requested a review from a team September 26, 2023 16:01
@maltesander maltesander self-assigned this Sep 26, 2023
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/105/

@razvan razvan requested review from razvan and removed request for a team September 27, 2023 07:01
razvan
razvan approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit f707dbd Sep 27, 2023
@bors bors bot deleted the let-secret-op-create-pkcs12-stores branch September 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let secret-operator handle PKCS#12 conversion
2 participants
@maltesander @razvan