[Merged by Bors] - feat: Support podOverrides #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
bors bot
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
Jul 6, 2023
Required for: stackabletech/spark-k8s-operator#256 - Make pub_overrides_schema public. - Make PodTemplateSpec implement Atomic. - Update CHANGELOG.md Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
requested changes
Jul 6, 2023
Comment on lines
8
to
10
| {% if lookup('env', 'VECTOR_AGGREGATOR') %} | ||
| vectorAggregatorConfigMapName: vector-aggregator-discovery | ||
| {% endif %} |
There was a problem hiding this comment.
Why did you remove logging to vector? (we try to log to log.t2.stackable.tech vector for all testcases to better debug tests)
There was a problem hiding this comment.
Ah, I haven't thought of that. I wanted to have cleaner tests.
There was a problem hiding this comment.
I would prefer to keep logging to e.g. collect the exceptions that occurred when the test failed
--- PASS: kuttl (102.96s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0-stackable0.0.0-dev (90.95s)
PASS
sbernauer
reviewed
Jul 7, 2023
Comment on lines
8
to
10
| {% if lookup('env', 'VECTOR_AGGREGATOR') %} | ||
| vectorAggregatorConfigMapName: vector-aggregator-discovery | ||
| {% endif %} |
There was a problem hiding this comment.
I would prefer to keep logging to e.g. collect the exceptions that occurred when the test failed
sbernauer
reviewed
Jul 7, 2023
sbernauer
requested changes
Jul 7, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
# Description Blocked by: stackabletech/operator-rs#616 Part of stackabletech/issues#346 Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
# Description Introduced in #256
sbernauer
added a commit
that referenced
this pull request
Jul 18, 2023
# Description Introduced in #256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked by: stackabletech/operator-rs#616
Part of stackabletech/issues#346
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information