-
-
Notifications
You must be signed in to change notification settings - Fork 15
fix!: Correctly construct OIDC endpoints #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly minor comments.
Also, we should maybe think about default to an empty string instead.
|
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Even when you change the default to an empty string it currently still returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor comments.
Co-authored-by: Techassi <git@techassi.dev>
Release notesAll the affected operators are listed below
Snippet: Operators have been fixed to work correctly with OpenID Connect rootPaths with and without trailing slashes. |
Description
Related to stackabletech/nifi-operator#716, but also will fix stuff in all other tools using OIDC (at least Superset and Trino)
Implementations
Definition of Done Checklist