Skip to content

fix!: Correctly construct OIDC endpoints #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 22, 2024

Description

Related to stackabletech/nifi-operator#716, but also will fix stuff in all other tools using OIDC (at least Superset and Trino)

Implementations

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title fix: Calculation of OIDC endpoint fix!: Calculation of OIDC endpoint Nov 22, 2024
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly minor comments.

@Techassi Techassi changed the title fix!: Calculation of OIDC endpoint fix!: Correctly construct OIDC endpoints Nov 22, 2024
@Techassi
Copy link
Member

Also, we should maybe think about default to an empty string instead.

/// Root HTTP path of the identity provider. Defaults to `/`.
#[serde(default = "default_root_path")]
root_path: String,

@sbernauer
Copy link
Member Author

Also, we should maybe think about default to an empty string instead.

Even when you change the default to an empty string it currently still returns https://my.keycloak.server/. I personally fine the / a bit more intuitive default (regardless if we strip trailing slashes anyway)

@sbernauer sbernauer requested a review from Techassi November 22, 2024 13:23
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments.

Co-authored-by: Techassi <git@techassi.dev>
@sbernauer sbernauer requested a review from Techassi November 22, 2024 14:40
@sbernauer sbernauer enabled auto-merge November 22, 2024 14:44
@sbernauer sbernauer added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit de15662 Nov 22, 2024
10 checks passed
@sbernauer
Copy link
Member Author

sbernauer commented Dec 12, 2024

Release notes

All the affected operators are listed below in the description.

  • Nifi Operator
  • Trino Operator
  • Druid Operator
  • Airflow Operator
  • Superset Operator

Snippet:

Operators have been fixed to work correctly with OpenID Connect rootPaths with and without trailing slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/24.11.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants