[Merged by Bors] - Adds structs to allow configuring resource limits and storage parameters

[soenkeliebau]

Signed-off-by: Sönke Liebau soenke.liebau@stackable.de

Description

These structs are intended for use by operators to offer a consistent interface across the entire platform.

Review Checklist

• Code contains useful comments
• (Integration-)Test cases added (or not applicable)
• Documentation added (or not applicable)
• Changelog updated (or not applicable)
• Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

[maltesander]

Would it make sense to implement some basic helper methods like create pvc (from PvcConfig) etc.?

[soenkeliebau]

Would it make sense to implement some basic helper methods like create pvc (from PvcConfig) etc.?

I have added a fn to do this. I considered the options a bit, ideally I'd like to impl Into<VolumeBuilder> for PvcConfig, but name is required on the constructor of the builder so that doesn't work.

I think just having a fn that returns a builder might make more sense than returning a fully built volumeclaim?

@teozkr any thoughts?

[nightkr]

To be honest, the FooBuilder-Foo distinction is somewhat arbitrary anyway. I'd be fine with either, but I think returning FooBuilder makes sense.

[soenkeliebau]

I have decided to leave it as is :)

The VolumeBuilder is at the volume level and expects a ready-made pvc, so lets return a pvc from here that can then be stuck into a volumebuilder if needed.

[maltesander]

LGTM.

[sbernauer]

I have on small request: We introduced a new module commons where we put all the common structs (currently available on the main branch).
Could you move you're resources.rs there?

[soenkeliebau]

bors r+

[soenkeliebau]

bors cancel

[bors]

Canceled.

[sbernauer]

LGTM % failing clippy check

[soenkeliebau]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• All tests passed