Skip to content

Commit 9147d0b

Browse files
committed
chore: Adjust FIXME comment
1 parent 4e34662 commit 9147d0b

File tree

1 file changed

+5
-4
lines changed
  • crates/stackable-versioned-macros/src/codegen/item

1 file changed

+5
-4
lines changed

crates/stackable-versioned-macros/src/codegen/item/variant.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ impl VersionedVariant {
2929

3030
let variant_ident = VariantIdent::from(variant.ident);
3131

32-
// FIXME (@Techassi): As we currently don't support enum variants with
33-
// data, we just return the Never type as the code generation code for
34-
// enum variants won't use this type information.
32+
// FIXME (@Techassi): The chain of changes currently doesn't track versioning of variant
33+
// date and as such, we just use the never type here. During codegen, we just re-emit the
34+
// variant data as is.
3535
let ty = Type::Never(TypeNever {
3636
bang_token: Not([Span::call_site()]),
3737
});
@@ -65,7 +65,8 @@ impl VersionedVariant {
6565
let fields = &self.fields;
6666

6767
match &self.changes {
68-
// NOTE (@Techassi): `unwrap_or_else` used instead of `expect`. See: https://rust-lang.github.io/rust-clippy/master/index.html#/expect_fun_call
68+
// NOTE (@Techassi): `unwrap_or_else` used instead of `expect`.
69+
// See: https://rust-lang.github.io/rust-clippy/master/index.html#/expect_fun_call
6970
Some(changes) => match changes.get(&version.inner).unwrap_or_else(|| {
7071
panic!(
7172
"internal error: chain must contain container version {}",

0 commit comments

Comments
 (0)