chore(webhook): Hide ByteString in instrumentation (#1137)

Techassi · web-flow · commit 8085d7727faa · 2026-01-12T14:01:26.000Z
* chore(webhook): Hide ByteString in instrumentation

* chore(webhook): Also hide the ByteString in the rotation handlers
diff --git a/crates/stackable-webhook/src/webhooks/conversion_webhook.rs b/crates/stackable-webhook/src/webhooks/conversion_webhook.rs
@@ -135,7 +135,7 @@ impl<H> ConversionWebhook<H> {
     }
 
     #[instrument(
-        skip(self, crd, crd_api),
+        skip(self, crd, crd_api, new_ca_bundle),
         fields(
             name = crd.name_any(),
             kind = &crd.spec.names.kind
@@ -244,7 +244,7 @@ where
         self.options.disable_crd_maintenance
     }
 
-    #[instrument(skip(self))]
+    #[instrument(skip(self, new_ca_bundle))]
     async fn handle_certificate_rotation(
         &mut self,
         new_ca_bundle: &ByteString,
diff --git a/crates/stackable-webhook/src/webhooks/mutating_webhook.rs b/crates/stackable-webhook/src/webhooks/mutating_webhook.rs
@@ -206,7 +206,7 @@ where
         self.options.disable_mwc_maintenance
     }
 
-    #[instrument(skip(self))]
+    #[instrument(skip(self, new_ca_bundle))]
     async fn handle_certificate_rotation(
         &mut self,
         new_ca_bundle: &ByteString,

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ where`
`206`	`206`	`self.options.disable_mwc_maintenance`
`207`	`207`	`}`
`208`	`208`
`209`		`- #[instrument(skip(self))]`
	`209`	`+ #[instrument(skip(self, new_ca_bundle))]`
`210`	`210`	`async fn handle_certificate_rotation(`
`211`	`211`	`&mut self,`
`212`	`212`	`new_ca_bundle: &ByteString,`