Skip to content

Commit 16ce3fa

Browse files
authored
fix(stackable-telemetry): Disable export of h2 events via OTLP (#796)
* fix(stackable-telemetry): disable export of h2 events via OTLP It causes infinite cascading events to be emitted. See open-telemetry/opentelemetry-rust#761 * chore(stackable-telemetry): update changelog
1 parent 231ec0b commit 16ce3fa

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

crates/stackable-telemetry/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,11 @@ All notable changes to this project will be documented in this file.
1212
- Bump GitHub workflow actions ([#772]).
1313
- Revert `zeroize` version bump ([#772]).
1414

15+
### Fixed
16+
17+
- Prevent infinite events being exported via OTLP, as described in [open-telemetry/opentelemetry-rust#761] ([#796]).
18+
1519
[#772]: https://github.com/stackabletech/operator-rs/pull/772
1620
[#782]: https://github.com/stackabletech/operator-rs/pull/782
21+
[#796]: https://github.com/stackabletech/operator-rs/pull/796
22+
[open-telemetry/opentelemetry-rust#761]: https://github.com/open-telemetry/opentelemetry-rust/issues/761

crates/stackable-telemetry/src/tracing.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ impl Tracing {
149149
if self.otlp_log_config.enabled {
150150
let env_filter_layer = EnvFilter::builder()
151151
.with_default_directive(self.otlp_log_config.level_filter.into()) // TODO (@NickLarsenNZ): support Directives
152-
.from_env_lossy();
152+
.from_env_lossy()
153+
// TODO (@NickLarsenNZ): Remove this directive once https://github.com/open-telemetry/opentelemetry-rust/issues/761 is resolved
154+
.add_directive("h2=off".parse().expect("invalid directive"));
153155

154156
let log_exporter = opentelemetry_otlp::new_exporter().tonic();
155157
let otel_log =
@@ -173,13 +175,9 @@ impl Tracing {
173175
if self.otlp_trace_config.enabled {
174176
let env_filter_layer = EnvFilter::builder()
175177
.with_default_directive(self.otlp_trace_config.level_filter.into()) // TODO (@NickLarsenNZ): support Directives
176-
.from_env_lossy();
177-
// .add_directive("hyper=info".parse().expect("invalid directive"))
178-
// .add_directive("tonic=warn".parse().expect("invalid directive"))
179-
// .add_directive("tokio_util=warn".parse().expect("invalid directive"))
180-
// .add_directive("hyper=info".parse().expect("invalid directive"))
181-
// .add_directive("h2=info".parse().expect("invalid directive"))
182-
// .add_directive("tower=info".parse().expect("invalid directive"));
178+
.from_env_lossy()
179+
// TODO (@NickLarsenNZ): Remove this directive once https://github.com/open-telemetry/opentelemetry-rust/issues/761 is resolved
180+
.add_directive("h2=off".parse().expect("invalid directive"));
183181

184182
let trace_exporter = opentelemetry_otlp::new_exporter().tonic();
185183
let otel_tracer = opentelemetry_otlp::new_pipeline()

0 commit comments

Comments
 (0)