Fix for custom images in OIDC test (#687)

* Fix for custom images in OIDC test

* fix pre-commit check

* check if nifi version > 1.x

---------

Co-authored-by: Benedikt Labrenz <benedikt@labrenz.org>

Author: lfrancke

tests/templates/kuttl/oidc/login.py

@@ -24,11 +24,15 @@
     else f"http://{keycloak_service}:8080"
 )
 
-if nifi_version in ["2.0.0-M4"]:
+# startswith instead of an exact check to
+# a) hit all 2.x versions and
+# b) to allow for custom images because `nifi_version` will contain the whole custom image string
+# e.g. 2.0.0-M4,localhost:5000/stackable/nifi:2.0.0-M4-stackable0.0.0-dev
+if not nifi_version.startswith("1."):
     auth_config_page = session.get(
         f"https://{nifi}:8443/nifi-api/authentication/configuration",
         verify=False,
-        headers={"Content-type": "application/json"}
+        headers={"Content-type": "application/json"},
     )
     assert auth_config_page.ok, "Could not fetch auth config from NiFi"
     auth_config = json.loads(auth_config_page.text)
@@ -44,7 +48,10 @@
 )
 
 print("actual: ", login_page.url)
-print("expected: ", f"{keycloak_base_url}/realms/test/protocol/openid-connect/auth?response_type=code&client_id=nifi&scope=")
+print(
+    "expected: ",
+    f"{keycloak_base_url}/realms/test/protocol/openid-connect/auth?response_type=code&client_id=nifi&scope=",
+)
 assert login_page.ok, "Redirection from NiFi to Keycloak failed"
 assert login_page.url.startswith(
     f"{keycloak_base_url}/realms/test/protocol/openid-connect/auth?response_type=code&client_id=nifi&scope="
@@ -54,7 +61,9 @@
 login_page_html = BeautifulSoup(login_page.text, "html.parser")
 authenticate_url = login_page_html.form["action"]
 welcome_page = session.post(
-    authenticate_url, data={"username": "jane.doe", "password": "T8mn72D9"}, verify=False
+    authenticate_url,
+    data={"username": "jane.doe", "password": "T8mn72D9"},
+    verify=False,
 )
 assert welcome_page.ok, "Login failed"
 assert (