You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Automatically created PR based on commit cdfb2668bda5687b386a80ba7390bc8830493b2e in stackabletech/operator-templating repo.
Triggered by:
Manual run triggered by: soenkeliebau with message [Update review checklist]
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+24-6Lines changed: 24 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -5,14 +5,32 @@
5
5
6
6
<!-- Commit message above. Everything below is not added to the message. Do not change this line! -->
7
7
8
-
## Review Checklist
8
+
## Definition of Done Checklist
9
9
10
+
- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
11
+
- Please make sure all these things are done and tick the boxes
12
+
13
+
```[tasklist]
14
+
# Author
15
+
- [ ] Changes are OpenShift compatible
16
+
- [ ] CRD changes approved
17
+
- [ ] Helm chart can be installed and deployed operator works
18
+
- [ ] Integration tests passed (for non trivial changes)
19
+
```
20
+
21
+
```[tasklist]
22
+
# Reviewer
10
23
- [ ] Code contains useful comments
11
-
-[ ] CRD change approved (or not applicable)
12
-
-[ ] (Integration-)Test cases added (or not applicable)
13
-
-[ ] Documentation added (or not applicable)
14
-
-[ ] Changelog updated (or not applicable)
24
+
- [ ] (Integration-)Test cases added
25
+
- [ ] Documentation added or updated
26
+
- [ ] Changelog updated
15
27
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
16
-
-[ ] Helm chart can be installed and deployed operator works (or not applicable)
28
+
```
29
+
30
+
```[tasklist]
31
+
# Acceptance
32
+
- [ ] Feature Tracker has been updated
33
+
- [ ] Proper release label has been added
34
+
```
17
35
18
36
Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
0 commit comments