Skip to content

Listener support/external access #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 26, 2024
Merged

Listener support/external access #450

merged 34 commits into from
Jan 26, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 8, 2024

Description

Fixes #174, supersedes #175.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Tasks before R4R
- [x] Support external access
- [x] Support Kerberos
- [ ] https://github.com/stackabletech/docker-images/pull/506
- [x] Move listenerclass into role config? https://stackable-workspace.slack.com/archives/C02FZ581UCD/p1704714818413279
- [ ] Add proper listener watch for discovery
- [x] Docs
- [ ] Tests
# Author
- [ ] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@soenkeliebau
Copy link
Member

Should we close #175 to avoid confusion?

@nightkr
Copy link
Member Author

nightkr commented Jan 8, 2024

Sounds good yeah.

@nightkr
Copy link
Member Author

nightkr commented Jan 12, 2024

Watching is blocked on stackabletech/listener-operator#138, but I wouldn't block on that since most expected changes here would be during startup/scale events (which would ping the operator anyway).

We'd still want to pull that out into an issue here and fix eventually, obviously.

@nightkr
Copy link
Member Author

nightkr commented Jan 15, 2024

The current testing approach is blocked on kudobuilder/kuttl#322. Are we okay to punt on testing external access as long as the internal access tests still function?

@nightkr nightkr marked this pull request as ready for review January 16, 2024 12:59
@nightkr nightkr requested a review from a team January 16, 2024 12:59
@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team January 17, 2024 12:33
@nightkr nightkr added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 2d751d7 Jan 26, 2024
@nightkr nightkr deleted the feat/listener branch January 26, 2024 12:00
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2024
…466)

* fix(tests): Migrate breaking changes from #450 listener integration

* fix: NN should use external-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow external access to the HDFS cluster
4 participants