Skip to content

chore(spark): update container images for 25.7.0 #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

razvan
Copy link
Member

@razvan razvan commented May 5, 2025

Description

Part of #1080

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

"hbase": "2.6.1", # current Stackable LTS version
"aws_java_sdk_bundle": "1.12.367", # https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-aws/3.3.6
"azure_storage": "7.0.1", # https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-azure/3.3.6
"hadoop": "3.4.1", # Hadoop version defined in ../hbase/versions.py to reduce build time and disk requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I didn't realise we could bump it for an existing version.
Hopefully we can do the same for Hive (otherwise I have to keep 3.3.6 around).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment in there because it's misleading. Spark is not built against this version at all. This argument is only used to extract the hadoop/cloud connectors from the Hadoop LTS version and add them to the Spark classpath.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated
@@ -57,6 +57,7 @@ All notable changes to this project will be documented in this file.

- ci: Remove Nexus steps from build, mirror and release workflows ([#1056]).
Also remove the old release workflow.
- spark: remove 3.5.2 and update dependencies for 3.5.5 ([#1094])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think update dependencies for 3.5.5 can go under the Changes heading.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razvan
Copy link
Member Author

razvan commented May 6, 2025

Currently doesn't build because of missing HBase 2.6.2 image

"azure_storage": "7.0.1", # https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-azure/3.3.6
"hadoop": "3.4.1", # Current Stackable LTS version. Source of the AWS and Azure artifacts to Spark's classpath.
"hbase": "2.6.2", # Current Stackable LTS version. Used to build the HBase connector.
"aws_java_sdk_bundle": "1.12.720", # https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-aws/3.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, this mentions:

aws-java-sdk-bundle-1.12.x.jar becomes bundle-2.x.y.jar

And I do see: bundle-2.24.6.jar in /stackable/hadoop-3.4.1/share/hadoop/tools/lib/.

I only see aws-java-sdk-bundle-1.12.367.jar for hadoop 3.3.6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. good catch

NickLarsenNZ
NickLarsenNZ previously approved these changes May 6, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants