-
Notifications
You must be signed in to change notification settings - Fork 25
Add support for S_CONTAINS
, S_WITHIN
, S_DISJOINT
spatial operations
#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @TravisYeah, this looks really cool. Can you lint the code so the tests will start. A |
@jonhealy1 thanks for the quick look. Fixed the formatting and the pre-commit passed now. |
@TravisYeah These tests pass locally? I am not sure what the issue is immediately .. |
Only the within tests are failing? |
The polygon dimensions in the test item and the polygon dimensions in the tests for the within operator are exactly the same? Maybe the polygon in the test has to be inside the one in the test item? Try running |
@jonhealy1 I was only running the elasticsearch tests and it seems that the opensearch within operator is more strict by default but I fixed the test to work for both now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TravisYeah Looks great. I am going to wait to merge this for a couple days just in case anyone else has any comments. Thanks.
Related Issue(s):
WITHIN
,CONTAIN
, andDISJOINT
#371Description:
Add support for
S_CONTAINS
,S_WITHIN
,S_DISJOINT
spatial operations.PR Checklist:
pre-commit run --all-files
)make test
)