[FIX-135]: Fix automatic converstion of float values to int #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuarte47
force-pushed
the
main_fix-filters-with-floats
branch
2 times, most recently
from
2d6fba5 to
13e07af
Compare
ahuarte47
force-pushed
the
main_fix-filters-with-floats
branch
from
13e07af to
34dea4b
Compare
|
That 3 failed tests are working in local and IMHO not related with this fix:
|
|
Thanks @jonhealy1 and @philvarner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Searching items filtering by properties with floats returns wrong results. Clause converts input query to ES filter using this Union. Because int is defined before float, all numeric values are converted to integer.
This fix takes care of value types, do not converting floats to int.
PR Checklist:
pre-commit run --all-files)make test)