Type issue: DatabaseLogic does not implement BaseDatabaseLogic

[Zaczero]

stac-fastapi-elasticsearch-opensearch/stac_fastapi/opensearch/stac_fastapi/opensearch/app.py

Lines 59 to 61 in b016945

	client=TransactionsClient(
	database=database_logic, session=session, settings=settings
	),

It seems to be intended for DatabaseLogic to be used as BaseDatabaseLogic but it doesn't inherit from it causing type issues. That's how abstract classes work. Perhaps you were meant to use a Protocol, but I wouldn't personally recommend that.

[Zaczero]

Similarly OpensearchSettings doesn't implement ApiBaseSettings but it's used as such. 👀

[jonhealy1]

@Zaczero Thanks for the feedback. Both should inherit. Would you be open to making a pr?