-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for RF6902 for path requests. #14
base: main
Are you sure you want to change the base?
Adding support for RF6902 for path requests. #14
Conversation
I've added the original |
@m-mohr would you be wiling to review this? |
This primarily needs to be in accordance with OGC APIs corresponding part. If we have an issue in STAC, OGC may also have one. Can someone check with them? I'd probably be fine with this if OGC also adopts this. I'd try to avoid diverging from OGC. I'm traveling/on vacation the next 4 weeks so would only be able to review in November, I think. |
@m-mohr I've created an issue in the OGC Features repo and had confirmation that OGC is not exclusive to RFC 7396 and that the addition of RFC 6902 won't diverge from OGC. They haven't said they will add RFC 6902 but instead will add a disclaimer that JSON Merge Patch is not exclusive. Do you think a similar disclaimer should be added to STAC's PATCH? |
I think we should explicitly and clearly say that the "old" way is the default, but that the "new" way can be added in addition and be distinguished via content negotiation (media types). That's also how I understood Peter in the OGC issue. |
I've updated the description to state that merge-patch is the default and json-patch is optional. Merge-patch is also the method for base |
Thanks, good start. I think it should also be clearly started in the README.md |
Good point I've update the PATCH text to RFC 6902 is optional and additional to RFC 7396. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (from a theoretical perspective).
Would like to see another review from a practitioner, server and/or client implementor.
@philvarner have you had time to review this pull request? |
Related Issue(s):
Proposed Changes:
PATCH
.PATCH
.PR Checklist: