Various fixes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 650ebfc2363ced3e102b7a32f2266655e31c4593)
(cherry picked from commit 4c58525d98c1b09b41a9dcba02e616987a8fea2e)
(cherry picked from commit 50d0abb3317ac439a4e7495b185a64af9b7b9300)
(cherry picked from commit 5a545fd94dc19cb1ec1853ecb9bd313e56f34516)
(cherry picked from commit b3a865acd224e2773e3f16caceb83ad9b4100fc3)
(cherry picked from commit 9151db2a9a61d7f5fe52ff8836f18bbd0fd8933c)
(cherry picked from commit 43a979272d9addc29fbffc2e8542c5d96e993d73)
We only have this for windows in haskell.nix so far 😅
Without these, we'll end up with lots of > `getDirectoryContents:openDirStream: invalid argument (Invalid argument)` this is due to malloc failing (the malloc from the in-memory loaded libc). loading two libcs into the same process is never a good idea.
This is used by readCreateProcessWithExitCode.
Is this still true? It looks like @alexfmpe makes use of this PR in NixOS/nixpkgs#445672, but I don't see any additional GHC patches added there. What's missing to actually merge this? |
|
I think that refers to Note it's not applied for 9.12 Not sure about the other part
|
Fix iserv-proxy build on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores most of the iserv functionality. It also crucially adds support for iserv-symbols. This requires a GHC patch, and will only work with haskell.nix.