Cover sprintf in tests (#13)

staabm · web-flow · commit eb28b6f4cde7 · 2025-04-22T18:20:54.000+02:00
diff --git a/tests/Rules/MessageInterpolationRuleTest.php b/tests/Rules/MessageInterpolationRuleTest.php
@@ -36,6 +36,10 @@ public function testSymfonyExample(): void
                 'Using interpolated strings in log messages is potentially a security risk. Use PSR-3 placeholders instead.',
                 22,
             ],
+            [
+                'Using interpolated strings in log messages is potentially a security risk. Use PSR-3 placeholders instead.',
+                24,
+            ],
         ]);
     }
 
diff --git a/tests/Rules/data/symfony-example.php b/tests/Rules/data/symfony-example.php
@@ -20,6 +20,8 @@ function wrong(LoggerInterface $logger, string $s, $b)
     ]);
 
     $logger->info("Failed user login for {$_POST['username']}.");
+
+    $logger->error(\sprintf('Error with userId "%s"', $s));
 }
 
 function good(LoggerInterface $logger, bool $nativeBool)

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@ function wrong(LoggerInterface $logger, string $s, $b)`
`20`	`20`	`]);`
`21`	`21`
`22`	`22`	`$logger->info("Failed user login for {$_POST['username']}.");`
	`23`	`+`
	`24`	`+ $logger->error(\sprintf('Error with userId "%s"', $s));`
`23`	`25`	`}`
`24`	`26`
`25`	`27`	`function good(LoggerInterface $logger, bool $nativeBool)`