Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OS to choose the best protocol to use #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lwalejko
Copy link

As per documentation (https://docs.microsoft.com/en-us/dotnet/api/system.security.authentication.sslprotocols?view=netframework-4.8), None should be used as default value, not Default, because Default allows only outdated and less secure protocols.

…hat are not secure.

This setting is recommended by SslProtocols Enum documentation.
@lwalejko lwalejko marked this pull request as ready for review June 21, 2019 09:36
Copy link

@eynzhang eynzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this as I encountered same issue when initializing the connection, and I found the same root cause while looking at the source code.

@lwalejko
Copy link
Author

lwalejko commented Dec 10, 2019

I forgot about this pull request to be honest ;)

@eynzhang have you tried if this change works for you as intended? I had some more problems with this and ended up using System.Security.Authentication.SslProtocols.Tls12 value directly.

@eynzhang
Copy link

I think that’s depends on the settings in server, in my cases ‘None’ is working for me.

That’s why I proposed a request on the readme document here:
#583

Maybe a better way is to pass this property by the constructor or a public method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants