split parser is keeping quotes

[ssube]

Summary

The split parser is retaining quotes in the data, which breaks some controllers, such as math.

Steps to Reproduce

• login
• !!math 1+1

• 2 (correct)

• !!math 1 + 1

• error evaluating math: Value expected (char 5) (a different issue)

• !!math "1 + 1"

• 1 + 1

Actual Behavior

1 + 1

Expected Behavior

2

Details

{"name":"isolex","hostname":"cerberus","pid":667,"kind":"function","level":20,"params":["[]","[[\"expr\",[\"\\\"1 + 1\\\"\\n\"]]]","math","create","bb5b7048-2548-4d58-82a2-20ab87100ae0","be45dafc-7d4c-4586-968c-127f074ca683"],"query":"INSERT INTO \"command\
"(\"createdAt\", \"updatedAt\", \"labels\", \"data\", \"noun\", \"verb\", \"id\", \"contextId\") VALUES (datetime('now'), datetime('now'), ?, ?, ?, ?, ?, ?)","msg":"orm logged query","time":"2019-09-27T00:33:11.609Z","v":0}

Judging by the params, the expression's quotes are being kept. There used to be a keepQuotes option in https://www.npmjs.com/package/split-string#optionsquotes, but it no longer appears in the documentation.

• add some test coverage around this
• fix the strip quotes config option