fix(tests): cover pairs to map helper

ssube · Oct 4, 2019 · f530266 · f530266
1 parent 6a52c2b
commit f530266
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/src/interval/MessageInterval.ts b/src/interval/MessageInterval.ts
@@ -27,8 +27,7 @@ export class MessageInterval extends BaseInterval<MessageIntervalData> {
   public async start() {
     await super.start();
 
-    const transforms: Array<ServiceDefinition<TransformData>> = this.data.transforms;
-    for (const def of transforms) {
+    for (const def of this.data.transforms) {
       const transform = await this.services.createService<Transform, TransformData>(def);
       this.transforms.push(transform);
     }

diff --git a/src/utils/Map.ts b/src/utils/Map.ts
@@ -124,12 +124,10 @@ export interface NameValuePair<TVal> {
   value: TVal;
 }
 
-export function pairsToMap<TVal>(pairs: Array<NameValuePair<TVal>> | undefined): Map<string, TVal> {
+export function pairsToMap<TVal>(pairs: Array<NameValuePair<TVal>>): Map<string, TVal> {
   const map = new Map();
-  if (doesExist(pairs)) {
-    for (const p of pairs) {
-      map.set(p.name, p.value);
-    }
+  for (const p of pairs) {
+    map.set(p.name, p.value);
   }
   return map;
 }

diff --git a/test/error/TestError.ts b/test/error/TestError.ts
@@ -5,6 +5,7 @@ import { MimeTypeError } from '../../src/error/MimeTypeError';
 import { MissingKeyError } from '../../src/error/MissingKeyError';
 import { NotFoundError } from '../../src/error/NotFoundError';
 import { NotImplementedError } from '../../src/error/NotImplementedError';
+import { NotInitializedError } from '../../src/error/NotInitializedError';
 import { SchemaError } from '../../src/error/SchemaError';
 import { SessionRequiredError } from '../../src/error/SessionRequiredError';
 import { TimeoutError } from '../../src/error/TimeoutError';
@@ -15,6 +16,7 @@ const errors = [
   MissingKeyError,
   NotFoundError,
   NotImplementedError,
+  NotInitializedError,
   SchemaError,
   SessionRequiredError,
   TimeoutError,

diff --git a/test/utils/TestMap.ts b/test/utils/TestMap.ts
@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 
 import { NotFoundError } from '../../src/error/NotFoundError';
-import { getHead, getHeadOrDefault, getOrDefault, makeDict, makeMap, mustGet } from '../../src/utils/Map';
+import { getHead, getHeadOrDefault, getOrDefault, makeDict, makeMap, mustGet, pairsToMap } from '../../src/utils/Map';
 import { describeLeaks, itLeaks } from '../helpers/async';
 
 const DEFAULT_VALUE = 'default';
@@ -79,4 +79,14 @@ describeLeaks('map utils', async () => {
     xit('should return the default for nil values');
     xit('should return falsy values for existing keys');
   });
+
+  describe('pairs to map helper', () => {
+    it('should convert pairs', () => {
+      const result = pairsToMap([{
+        name: 'foo',
+        value: 3,
+      }]);
+      expect(result.get('foo')).to.equal(3);
+    });
+  });
 });