fix(tests): add missing assertions, bubble ORM connection errors

src/Bot.ts

@@ -135,9 +135,7 @@ export class Bot extends BaseService<BotData> implements Service {
   public async start() {
     this.logger.info('starting bot');
 
-    const streamError = (err: Error) => {
-      this.logger.error(err, 'bot stream did not handle error');
-    };
+    const streamError = this.streamError.bind(this);
     this.commands.subscribe((next) => this.receiveCommand(next).catch(streamError));
     this.incoming.subscribe((next) => this.receive(next).catch(streamError));
     this.outgoing.subscribe((next) => this.receiveMessage(next).catch(streamError));
@@ -252,6 +250,10 @@ export class Bot extends BaseService<BotData> implements Service {
     }
   }
 
+  protected streamError(err: Error) {
+    this.logger.error(err, 'bot stream did not handle error');
+  }
+
   protected async findMessageTarget(msg: Message): Promise<void> {
     for (const target of this.listeners) {
       if (await target.check(msg)) {

src/storage/index.ts

@@ -50,6 +50,7 @@ export class Storage extends BaseService<StorageData> implements ServiceLifecycl
       }
     } catch (err) {
       this.logger.error(err, 'error connecting to storage');
+      throw err;
     }
   }
 

test/utils/TestPicklist.ts

@@ -54,6 +54,9 @@ describeLeaks('pick list', async () => {
     for (let i = 0; i < PICK_REPS; i += 1) {
       counter[list.pickOne()] += 1;
     }
+
+    expect(counter.x).to.be.greaterThan(0);
+    expect(counter.y).to.be.greaterThan(0);
   });
 
   itLeaks('should pick some weighted items', async () => {