fix(tests): cover keyword entity, duplicate service registration

Author: ssube

test/entity/misc/TestKeyword.ts

@@ -0,0 +1,21 @@
+import { expect } from 'chai';
+
+import { CommandVerb } from '../../../src/entity/Command';
+import { Keyword } from '../../../src/entity/misc/Keyword';
+import { describeLeaks, itLeaks } from '../../helpers/async';
+
+describeLeaks('keyword entity', async () => {
+  itLeaks('should convert itself to JSON', async () => {
+    const keyword = new Keyword({
+      controllerId: '',
+      data: {},
+      key: '',
+      labels: {},
+      noun: 'test',
+      verb: CommandVerb.Create,
+    });
+    const json = keyword.toJSON();
+    expect(json).to.have.property('noun');
+    expect(json).to.have.property('verb');
+  });
+});

test/migration/TestMigrations.ts

@@ -33,6 +33,7 @@ describeLeaks('database migrations', async () => {
       },
     });
     await storage.start();
+    await storage.stop();
   });
 
   itLeaks('should run down');

test/module/TestServiceModule.ts

@@ -1,12 +1,13 @@
 import { expect } from 'chai';
 import { ineeda } from 'ineeda';
+import { Logger } from 'noicejs';
 import { spy } from 'sinon';
 
 import { ServiceModule } from '../../src/module/ServiceModule';
 import { Service, ServiceEvent } from '../../src/Service';
 import { defer } from '../../src/utils/Async';
 import { describeLeaks, itLeaks } from '../helpers/async';
-import { createContainer } from '../helpers/container';
+import { createContainer, createServiceContainer } from '../helpers/container';
 
 const TEST_SERVICE_NAME = 'test-service';
 
@@ -76,6 +77,22 @@ describeLeaks('DI modules', async () => {
       expect(existing.has(tag)).to.equal(true);
     });
 
-    itLeaks('should warn when adding duplicate services');
+    itLeaks('should warn when adding duplicate services', async () => {
+      const { services } = await createServiceContainer();
+
+      const warn = spy();
+      services.logger = ineeda<Logger>({
+        warn,
+      });
+
+      const svc = ineeda<Service>({
+        kind: 'test',
+        name: 'service',
+      });
+      services.addService(svc);
+      services.addService(svc);
+
+      expect(warn).to.have.callCount(1);
+    });
   });
 });