fix: escape outgoing messages in listener

ssube · Dec 30, 2018 · 2c2c2c4 · 2c2c2c4
1 parent 51faabf
commit 2c2c2c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/src/entity/Message.ts b/src/entity/Message.ts
@@ -1,4 +1,3 @@
-import * as escape from 'escape-html';
 import { GraphQLInputObjectType, GraphQLList, GraphQLObjectType, GraphQLString } from 'graphql';
 import { Column, Entity, JoinColumn, OneToOne, PrimaryGeneratedColumn } from 'typeorm';
 
@@ -64,13 +63,6 @@ export class Message extends LabelEntity implements MessageOptions {
     }
   }
 
-  /**
-   * @TODO: move this to each listener
-   */
-  get escaped(): string {
-    return escape(this.body);
-  }
-
   public toJSON(): object {
     return {
       body: this.body,

diff --git a/src/listener/DiscordListener.ts b/src/listener/DiscordListener.ts
@@ -9,6 +9,7 @@ import {
   TextChannel,
   User,
 } from 'discord.js';
+import * as escape from 'escape-html';
 import { isNil } from 'lodash';
 import * as emoji from 'node-emoji';
 import { Inject } from 'noicejs';
@@ -113,7 +114,7 @@ export class DiscordListener extends SessionListener<DiscordListenerData> implem
     }
 
     if (msg.body.length) {
-      await thread.reply(msg.body);
+      await thread.reply(escape(msg.body));
     }
 
     const reactions = this.filterEmoji(msg.reactions);
@@ -137,7 +138,7 @@ export class DiscordListener extends SessionListener<DiscordListenerData> implem
       return;
     }
 
-    await channel.send(msg.body);
+    await channel.send(escape(msg.body));
     return;
   }
 

diff --git a/src/listener/SlackListener.ts b/src/listener/SlackListener.ts
@@ -1,4 +1,5 @@
 import { RTMClient, WebClient } from '@slack/client';
+import * as escape from 'escape-html';
 import { isNil } from 'lodash';
 import { BaseError, Inject, logWithLevel } from 'noicejs';
 
@@ -30,7 +31,7 @@ export class SlackListener extends SessionListener<SlackListenerData> implements
 
   public async send(msg: Message): Promise<void> {
     if (msg.context.channel.id) {
-      const result = await this.client.sendMessage(msg.body, msg.context.channel.id);
+      const result = await this.client.sendMessage(escape(msg.body), msg.context.channel.id);
       if (result.error) {
         const err = new BaseError(result.error.msg);
         this.logger.error(err, 'error sending slack message');