Adjust prettier config to match eslint #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslint wants single parens around arrow functions, but prettier was removing them, leading to annoying lint errors. This fixes it by adjusting the prettier config to match the eslint config. An even better fix would be to use `eslint-config-prettier`, which disables all lint rules related to style, as checking the style with eslint is unnecessary when using prettier. That being said, this should be good enough for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint wants single parens around arrow functions, but prettier was
removing them, leading to annoying lint errors.
This fixes it by adjusting the prettier config to match the eslint config.
An even better fix would be to use
eslint-config-prettier,which disables all lint rules related to style, as checking the style
with eslint is unnecessary when using prettier.
That being said, this should be good enough for now.