Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --print-computed-version flag output is incorrect #18

Closed
KealanM opened this issue Feb 11, 2020 · 3 comments · Fixed by #19
Closed

The --print-computed-version flag output is incorrect #18

KealanM opened this issue Feb 11, 2020 · 3 comments · Fixed by #19

Comments

@KealanM
Copy link

KealanM commented Feb 11, 2020

When you supply the --print-computed-version the version print to stdout is incorrect as it does not factor in the git commits, sha or branch naming elements.

Example

helm release ./helm/test --print-computed-version
0.2.1

helm release ./helm/test
INFO[0000] updating the Chart.yaml to version 0.2.1-0.development+c409e7f

Is this intended? It would appear some changes to the logic after that flag was introduced changed the order of calls and resulted in the printed version being incorrect. But just want to check.

@sstarcher
Copy link
Owner

I'm currently trying to fathom why I did it that way.

The current --print-computed-version is relying on the bump flag.

@sstarcher
Copy link
Owner

Can you see if the above works as you expect?

@KealanM
Copy link
Author

KealanM commented Feb 27, 2020

That looks exactly like the way i had a fix on a fork, I was just waiting on legal to be allowed contrib back. Thanks for the fix :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants