Skip to content

Commit 08a618e

Browse files
committed
Updated to 1.3.4 : Fixed possible index out of range exception on closing tabs that are being dragged.
1 parent 9185e51 commit 08a618e

File tree

4 files changed

+23
-5
lines changed

4 files changed

+23
-5
lines changed

ChromeTabs/ChromeTabControl.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,12 @@ internal void ChangeSelectedItem(ChromeTabItem item)
561561

562562
internal void MoveTab(int fromIndex, int toIndex)
563563
{
564-
if (Items.Count == 0 || fromIndex == toIndex || fromIndex >= Items.Count)
564+
if (Items.Count == 0
565+
|| fromIndex == toIndex
566+
|| fromIndex >= Items.Count
567+
|| fromIndex < 0
568+
|| toIndex >= Items.Count
569+
|| toIndex < 0)
565570
{
566571
return;
567572
}

ChromeTabs/ChromeTabPanel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ void completed()
575575
_draggedTab.Margin = new Thickness(offset, 0, -offset, 0);
576576
_draggedTab = null;
577577
_captureGuard = 0;
578-
ParentTabControl.MoveTab(_originalIndex, Math.Max(0, localSlideIndex - 1));
578+
ParentTabControl.MoveTab(_originalIndex, localSlideIndex - 1);
579579
_slideIntervals = null;
580580
_addButton.Visibility = Visibility.Visible;
581581
_hideAddButton = false;

ChromeTabs/ChromeTabs.csproj

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,26 @@
1313
<RootNamespace>ChromeTabs</RootNamespace>
1414
<AssemblyName>ChromeTabs</AssemblyName>
1515
<DelaySign>false</DelaySign>
16-
<Version>1.3.3</Version>
16+
<Version>1.3.4</Version>
1717
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1818
<PackageProjectUrl>https://github.com/sskodje/wpfchrometabs-mvvm</PackageProjectUrl>
1919
<PackageDescription>WPF chrome tabs is a tab control modeled after the tabs in Google's Chrome browser. Tabs can be reordered and snapped to/from windows.</PackageDescription>
20-
<PackageReleaseNotes>- Added support for .NET Core.</PackageReleaseNotes>
20+
<PackageReleaseNotes>- Fixed possible index out of range exception if closing tabs that are being dragged.</PackageReleaseNotes>
2121
<Description>WPF chrome tabs is a tab control modeled after the tabs in Google's Chrome browser. Tabs can be reordered and snapped to/from windows.</Description>
2222
<NeutralLanguage>en</NeutralLanguage>
2323
<Product>WPF Chrome Tabs - MVVM</Product>
2424
</PropertyGroup>
25+
<ItemGroup>
26+
<Compile Update="Properties\Settings.Designer.cs">
27+
<DesignTimeSharedInput>True</DesignTimeSharedInput>
28+
<AutoGen>True</AutoGen>
29+
<DependentUpon>Settings.settings</DependentUpon>
30+
</Compile>
31+
</ItemGroup>
32+
<ItemGroup>
33+
<None Update="Properties\Settings.settings">
34+
<Generator>SettingsSingleFileGenerator</Generator>
35+
<LastGenOutput>Settings.Designer.cs</LastGenOutput>
36+
</None>
37+
</ItemGroup>
2538
</Project>

ChromeTabs/Properties/Settings.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)