Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssh-rsa-cert-v01@openssh.com algorithm, added algorithm priorities #682

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

msvprogs
Copy link

@msvprogs msvprogs commented May 23, 2020

++ minor bug fixes.

msvprogs and others added 21 commits March 31, 2019 12:58
…ks on SSH/SFTP client disposing when SSH server is lagging)
… (might be SECURITY HOLE)""""

This reverts commit c649034.
…gorithms (might be SECURITY HOLE)"""""

This reverts commit be788d6.
This reverts commit 358ae9f.
@drieseng
Copy link
Member

Thanks a lot for taking time to create a PR for your changes.
However, in its current form this PR is not likely to be merged.
Please try discussing changes first, and split up the PR in smaller parts.
For example:

  • Create a PR to fix the NRE in Session.MessageListener(), and add a repro for this issue.
  • Create an issue to discuss prioritization of algorithms.

@msvprogs
Copy link
Author

Ok, I created the issue for prioritization. NRE in MessageListener occurs sporadically (somewhy after dotTrace profiler attaching?!), and I don't know what causes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants