remove Reverse extension to avoid source-breaking change with .NET 10 #1606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal array
Reverse
extension is already a little weird because it can be ambigious with Linq'sReverse(IEnumerable<T>)
, but behaves differently. It changes the passed array instance instead of creating a new one and returns an array instead of anIEnumerable<T>
..NET 10 introduces a
Enumerable.Reverse<T>(T[])
which causes even more ambiguity and returns anIEnumerable<T>
instead of an array, which causes some compilation errors with .NET 10:Looking at the usage, the
Reverse
extension is only needed in the context ofBigInteger
which already has extension methods to deal with endianness (but which were not used everywhere). So I think it makes most sense to just remove theReverse
extension.Also introduced a
ToBigInteger(this ReadOnlySpan<byte> data)
which is made use of inEcdsaKey.cs
.