Skip to content

Cleanup and muting of analyzer warnings #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 3, 2024

Conversation

jscarle
Copy link
Contributor

@jscarle jscarle commented Mar 15, 2024

As it currently stands, the analyzer warnings and messages make the analyzers overly difficult to follow. There are currently more that 32k messages for the entire solution:
Warnings

There are also new analyzer warnings coming in .NET 9.0. Therefore to bring some order to the chaos, I started by addressing the analyzer warnings and messages that could be easily fixed. I then switched all of the analyzer warnings from suggestion to silent for all test projects. I then set the remaining analyzer warnings in the main project to none.

In the future, I'll look into standardizing all of the analyzer configurations and merge everything down to two .editorconfigs files, one for the main project, and another for all of the tests, while also addressing as many warning as is logical.

@jscarle
Copy link
Contributor Author

jscarle commented Mar 15, 2024

@Rob-Hague FYI.

@Rob-Hague
Copy link
Collaborator

Thanks for tackling some of the noise. On initial look, I think test classes are supposed to be public? I can see that they are not running in CI

@jscarle
Copy link
Contributor Author

jscarle commented Mar 16, 2024

@WojciechNagorski @Rob-Hague Ready for review and merge.

@Rob-Hague
Copy link
Collaborator

@jscarle
Copy link
Contributor Author

jscarle commented Apr 3, 2024

@Rob-Hague All tests seem to be passing now. I also cleaned up the diff by removing any formatting changes to make it easier to review.

@Rob-Hague
Copy link
Collaborator

Thanks. CI managed to finish all 2951 tests on Ubuntu, so this is good to merge from me.

@WojciechNagorski WojciechNagorski merged commit 9be67c0 into sshnet:develop Apr 3, 2024
@jscarle jscarle deleted the feature/warnings branch April 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants