-
-
Notifications
You must be signed in to change notification settings - Fork 952
Cleanup and muting of analyzer warnings #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Rob-Hague FYI. |
Thanks for tackling some of the noise. On initial look, I think test classes are supposed to be public? I can see that they are not running in CI |
@WojciechNagorski @Rob-Hague Ready for review and merge. |
Something is wrong with CI... It crashed on the latest commit on this PR: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49517362/job/8rdxcr7v12990kdx?fullLog=true On some builds it is only running 840 tests on Ubuntu: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49516084 https://ci.appveyor.com/project/drieseng/ssh-net/builds/49513131 |
@Rob-Hague All tests seem to be passing now. I also cleaned up the diff by removing any formatting changes to make it easier to review. |
Thanks. CI managed to finish all 2951 tests on Ubuntu, so this is good to merge from me. |
As it currently stands, the analyzer warnings and messages make the analyzers overly difficult to follow. There are currently more that 32k messages for the entire solution:

There are also new analyzer warnings coming in .NET 9.0. Therefore to bring some order to the chaos, I started by addressing the analyzer warnings and messages that could be easily fixed. I then switched all of the analyzer warnings from
suggestion
tosilent
for all test projects. I then set the remaining analyzer warnings in the main project tonone
.In the future, I'll look into standardizing all of the analyzer configurations and merge everything down to two .editorconfigs files, one for the main project, and another for all of the tests, while also addressing as many warning as is logical.