Fix #1275. Hung Dispose() caused by infinite socket timeout #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkillingsworth
requested review from
WojciechNagorski and
drieseng
as code owners
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
jkillingsworth
force-pushed
the
fix-hung-dispose
branch
from
35e1cc9 to
347d289
Compare
|
@Rob-Hague Can you make a review? It's your idea. |
WojciechNagorski
approved these changes
Dec 28, 2023
Closed
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Thank you @WojciechNagorski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described in #1275. This fix is based on a suggestion by @Rob-Hague in #1275 (comment).
Note that I have suppressed the
S2222warning. I believe this to be a false positive. I don't see any execution paths where the lock does not get released.