Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SemaphoreLight with SemaphoreSlim #1265

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

Rob-Hague
Copy link
Collaborator

This paves the way for asynchronous synchronisation via WaitAsync (and eliminates a timing test which sometimes fails in CI)

This paves the way for asynchronous synchronisation via WaitAsync
(and eliminates a timing test which sometimes fails in CI)
@WojciechNagorski
Copy link
Collaborator

How do you know there is a problem with SemaphoreLight?

Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It is stable and I think it's better to use official semaphore.

@WojciechNagorski WojciechNagorski merged commit f45af38 into sshnet:develop Dec 9, 2023
1 check passed
@Rob-Hague Rob-Hague deleted the semaphore branch December 9, 2023 08:33
@Rob-Hague
Copy link
Collaborator Author

How do you know there is a problem with SemaphoreLight?

I looked through the recent builds and saw this one which had failed https://ci.appveyor.com/project/drieseng/ssh-net/builds/48640576/tests. I don't think it will fix any other tests

@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Dec 20, 2023
@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants