Skip to content

Tweak diagnostics #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Tweak diagnostics #1241

merged 2 commits into from
Nov 16, 2023

Conversation

Rob-Hague
Copy link
Collaborator

  • Make it work (it needs the TRACE symbol defined - lots of head scratching without it)

  • Expose publicly, but still in DEBUG (to allow programmatic configuration necessary in Core)

  • Document how to use it

  • Tweak usage (add some logs, remove key/iv information, override ToString on some Message types)

* Make it work (it needs the TRACE symbol defined - lots of head scratching without it)

* Expose publicly, but still in DEBUG (to allow programmatic configuration necessary in Core)

* Document how to use it

* Tweak usage (add some logs, remove key/iv information, override ToString on some Message types)
@WojciechNagorski
Copy link
Collaborator

This is a great idea! I'm going to use this in integration tests:
image

@WojciechNagorski WojciechNagorski merged commit b4c8291 into sshnet:develop Nov 16, 2023
@Rob-Hague Rob-Hague deleted the diagnostics branch November 16, 2023 07:40
@Rob-Hague
Copy link
Collaborator Author

@drieseng if you would be willing to give me access to the wiki, I will add some instructions to https://github.com/sshnet/SSH.NET/wiki/Troubleshooting-SSH.NET

@WojciechNagorski
Copy link
Collaborator

@Rob-Hague @drieseng I wanted to prepare a new web page something similar to https://docs.automapper.org/en/stable/ But I need to admin permissions to https://github.com/sshnet/sshnet.github.io
Until the first version is released, I don't want to ask for reviews all the time. Too much time.

@WojciechNagorski
Copy link
Collaborator

@Rob-Hague I made you a maintainer. Please let me know if you can edit right now.
FYI @drieseng

@Rob-Hague
Copy link
Collaborator Author

Thanks, I was able to make a test edit. I will update that page

@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Nov 16, 2023
@zybexXL
Copy link
Contributor

zybexXL commented Nov 20, 2023

@Rob-Hague, this doesn't compile for me in RELEASE mode, complains about 'Source' being undefined in DiagnosticAbstraction.cs:62 under Net7.0.

@Rob-Hague
Copy link
Collaborator Author

Thanks #1248

@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants