Skip to content

Delete performance/longrunning tests #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ build:

test_script:
- cmd: >-
vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net462\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration&TestCategory!=LongRunning" --blame
vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net462\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration" --blame

vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net7.0\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration&TestCategory!=LongRunning" --blame
vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net7.0\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration" --blame
241 changes: 0 additions & 241 deletions src/Renci.SshNet.Tests/Classes/Common/ASCIIEncodingTest.cs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this whole file: the custom ASCII class no longer exists, so it is just testing System.Text.Encoding.ASCII

This file was deleted.

56 changes: 0 additions & 56 deletions src/Renci.SshNet.Tests/Classes/Common/BigIntegerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
//#define FEATURE_NUMERICS_BIGINTEGER

using System;
using System.Diagnostics;
using System.Globalization;
using System.Threading;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -1559,61 +1558,6 @@ public void Bug16526()
}
}

[TestMethod]
[TestCategory("LongRunning")]
[TestCategory("Performance")]
public void ToArray_Performance()
{
const int loopCount = 100000000;
var bigInteger = new BigInteger(Huge_a);

var stopWatch = new Stopwatch();

GC.Collect();
_ = GC.WaitForFullGCComplete();

stopWatch.Start();

for (var i = 0; i < loopCount; i++)
{
_ = bigInteger.ToByteArray();
}

GC.Collect();
_ = GC.WaitForFullGCComplete();

stopWatch.Stop();

Console.WriteLine(stopWatch.ElapsedMilliseconds);
}

[TestMethod]
[TestCategory("LongRunning")]
[TestCategory("Performance")]
public void Ctor_ByteArray_Performance()
{
const int loopCount = 100000000;

var stopWatch = new Stopwatch();

GC.Collect();
_ = GC.WaitForFullGCComplete();

stopWatch.Start();

for (var i = 0; i < loopCount; i++)
{
_ = new BigInteger(Huge_a);
}

GC.Collect();
_ = GC.WaitForFullGCComplete();

stopWatch.Stop();

Console.WriteLine(stopWatch.ElapsedMilliseconds);
}

[TestMethod]
public void MinusOne()
{
Expand Down
Loading