Fix some IDE warnings

Author: srnyx

src/main/java/xyz/srnyx/annoyingapi/AnnoyingPlugin.java

@@ -515,7 +515,11 @@ private DataManager attemptDatabaseMigration(@NotNull DataManager oldManager) {
 
         // PREV: Delete storage-old.yml if it exists (from a previous migration)
         final File storageOld = new File(dataFolder, "storage-old.yml");
-        if (storageOld.exists() && !storageOld.delete()) log(Level.SEVERE, "&cFailed to delete previous &4storage-old.yml!");
+        if (storageOld.exists()) try {
+            Files.delete(storageOld.toPath());
+        } catch (final IOException e) {
+            log(Level.SEVERE, "&cFailed to delete previous &4storage-old.yml!");
+        }
 
         // Rename files
         final File storage = oldManager.storageConfig.file.file;

src/main/java/xyz/srnyx/annoyingapi/AnnoyingUpdate.java

@@ -4,7 +4,8 @@
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
 
-import org.bukkit.plugin.java.JavaPlugin;
+import org.bukkit.plugin.PluginBase;
+import org.bukkit.plugin.PluginDescriptionFile;
 
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -32,9 +33,9 @@ public class AnnoyingUpdate extends Stringable implements Annoyable {
      */
     @NotNull private final AnnoyingPlugin annoyingPlugin;
     /**
-     * The {@link JavaPlugin plugin} to check for updates
+     * The name of the plugin to check for updates
      */
-    @NotNull private final JavaPlugin plugin;
+    @NotNull private final String pluginName;
     /**
      * The current version of the plugin
      */
@@ -55,14 +56,14 @@ public class AnnoyingUpdate extends Stringable implements Annoyable {
     /**
      * Creates a new {@link AnnoyingUpdate} object
      *
-     * @param   annoyingPlugin  {@link #annoyingPlugin}
-     * @param   plugin          {@link #plugin}
-     * @param   platforms       {@link #platforms}
+     * @param   annoyingPlugin      {@link #annoyingPlugin}
+     * @param   pluginDescription   {@link #pluginName} and {@link #currentVersion}
+     * @param   platforms           {@link #platforms}
      */
-    public AnnoyingUpdate(@NotNull AnnoyingPlugin annoyingPlugin, @NotNull JavaPlugin plugin, @NotNull PluginPlatform.Multi platforms) {
+    public AnnoyingUpdate(@NotNull AnnoyingPlugin annoyingPlugin, @NotNull PluginDescriptionFile pluginDescription, @NotNull PluginPlatform.Multi platforms) {
         this.annoyingPlugin = annoyingPlugin;
-        this.plugin = plugin;
-        this.currentVersion = new SemanticVersion(plugin.getDescription().getVersion());
+        this.pluginName = pluginDescription.getName();
+        this.currentVersion = new SemanticVersion(pluginDescription.getVersion());
         this.userAgent = annoyingPlugin.getName() + "/" + annoyingPlugin.getDescription().getVersion() + " via Annoying API (update)";
         this.platforms = platforms;
         final String latestVersionString = getLatestVersion();
@@ -72,7 +73,18 @@ public AnnoyingUpdate(@NotNull AnnoyingPlugin annoyingPlugin, @NotNull JavaPlugi
     /**
      * Creates a new {@link AnnoyingUpdate} object
      *
-     * @param   plugin      {@link #annoyingPlugin} and {@link #plugin}
+     * @param   annoyingPlugin  {@link #annoyingPlugin}
+     * @param   plugin          {@link #pluginName} and {@link #currentVersion}
+     * @param   platforms       {@link #platforms}
+     */
+    public AnnoyingUpdate(@NotNull AnnoyingPlugin annoyingPlugin, @NotNull PluginBase plugin, @NotNull PluginPlatform.Multi platforms) {
+        this(annoyingPlugin, plugin.getDescription(), platforms);
+    }
+
+    /**
+     * Creates a new {@link AnnoyingUpdate} object
+     *
+     * @param   plugin      {@link #annoyingPlugin}, {@link #pluginName}, and {@link #currentVersion}
      * @param   platforms   {@link #platforms}
      */
     public AnnoyingUpdate(@NotNull AnnoyingPlugin plugin, @NotNull PluginPlatform.Multi platforms) {
@@ -93,7 +105,7 @@ public AnnoyingPlugin getAnnoyingPlugin() {
     public boolean checkUpdate() {
         final boolean update = isUpdateAvailable();
         if (update && latestVersion != null) new AnnoyingMessage(annoyingPlugin, annoyingPlugin.options.messagesOptions.keys.updateAvailable)
-                .replace("%plugin%", plugin.getName())
+                .replace("%plugin%", pluginName)
                 .replace("%current%", currentVersion.version)
                 .replace("%new%", latestVersion.version)
                 .log(Level.WARNING);

src/main/java/xyz/srnyx/annoyingapi/command/AnnoyingCommand.java

@@ -42,7 +42,7 @@ public AnnoyingCommand() {
      */
     @NotNull
     public String getName() {
-        return getClass().getSimpleName().toLowerCase().replace("command", "").replace("cmd", "");
+        return getClass().getSimpleName().replace("Command", "").replace("Cmd", "").toLowerCase();
     }
 
     /**

src/main/java/xyz/srnyx/annoyingapi/message/AnnoyingMessage.java

@@ -343,13 +343,13 @@ public void broadcast(@NotNull BroadcastType type, @Nullable AnnoyingSender send
                     fadeIn, stay, fadeOut);
             return;
         }
-        final BaseComponent[] components = getComponents(sender);
+        final BaseComponent[] compiledComponents = getComponents(sender);
 
         // Action bar
         if (type.equals(BroadcastType.ACTIONBAR) && PLAYER_SPIGOT_SEND_MESSAGE_METHOD != null) {
             Bukkit.getOnlinePlayers().forEach(player -> {
                 try {
-                    PLAYER_SPIGOT_SEND_MESSAGE_METHOD.invoke(player.spigot(), ChatMessageType.ACTION_BAR, components);
+                    PLAYER_SPIGOT_SEND_MESSAGE_METHOD.invoke(player.spigot(), ChatMessageType.ACTION_BAR, compiledComponents);
                 } catch (final IllegalAccessException | InvocationTargetException e) {
                     e.printStackTrace();
                 }
@@ -358,7 +358,7 @@ public void broadcast(@NotNull BroadcastType type, @Nullable AnnoyingSender send
         }
 
         // Chat
-        Bukkit.spigot().broadcast(components);
+        Bukkit.spigot().broadcast(compiledComponents);
     }
 
     /**