fix code smells

Author: code-not-found

spring-batch-capitalize-names/src/main/java/com/codenotfound/batch/job/CapitalizeNamesJobConfig.java

@@ -9,7 +9,6 @@
 import org.springframework.batch.item.file.FlatFileItemWriter;
 import org.springframework.batch.item.file.builder.FlatFileItemReaderBuilder;
 import org.springframework.batch.item.file.builder.FlatFileItemWriterBuilder;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.io.ClassPathResource;
@@ -20,19 +19,13 @@
 @EnableBatchProcessing
 public class CapitalizeNamesJobConfig {
 
-  @Autowired
-  public JobBuilderFactory jobBuilders;
-
-  @Autowired
-  public StepBuilderFactory stepBuilders;
-
   @Bean
-  public Job convertNamesJob() {
-    return jobBuilders.get("capitalizeNamesJob").start(convertNamesStep()).build();
+  public Job convertNamesJob(JobBuilderFactory jobBuilders, StepBuilderFactory stepBuilders) {
+    return jobBuilders.get("capitalizeNamesJob").start(convertNamesStep(stepBuilders)).build();
   }
 
   @Bean
-  public Step convertNamesStep() {
+  public Step convertNamesStep(StepBuilderFactory stepBuilders) {
     return stepBuilders.get("capitalizeNamesStep").<Person, Person>chunk(10).reader(itemReader())
         .processor(itemProcessor()).writer(itemWriter()).build();
   }

spring-batch-capitalize-names/src/main/java/com/codenotfound/model/Person.java

@@ -4,7 +4,9 @@ public class Person {
   private String firstName;
   private String lastName;
 
-  public Person() {}
+  public Person() {
+    // default constructor
+  }
 
   public String getFirstName() {
     return firstName;

spring-batch-tasklet/src/main/java/com/codenotfound/batch/job/CapitalizeNamesJobConfig.java

@@ -14,7 +14,6 @@
 import org.springframework.batch.item.file.builder.FlatFileItemReaderBuilder;
 import org.springframework.batch.item.file.builder.FlatFileItemWriterBuilder;
 import org.springframework.batch.item.file.builder.MultiResourceItemReaderBuilder;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.io.FileSystemResource;
@@ -29,23 +28,20 @@ public class CapitalizeNamesJobConfig {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(CapitalizeNamesJobConfig.class);
 
-  @Autowired
-  public StepBuilderFactory stepBuilders;
-
   @Bean
-  public Job capitalizeNamesJob(JobBuilderFactory jobBuilders) {
-    return jobBuilders.get("capitalizeNamesJob").start(capitalizeNamesStep())
-        .next(deleteFilesStep()).build();
+  public Job capitalizeNamesJob(JobBuilderFactory jobBuilders, StepBuilderFactory stepBuilders) {
+    return jobBuilders.get("capitalizeNamesJob").start(capitalizeNamesStep(stepBuilders))
+        .next(deleteFilesStep(stepBuilders)).build();
   }
 
   @Bean
-  public Step capitalizeNamesStep() {
+  public Step capitalizeNamesStep(StepBuilderFactory stepBuilders) {
     return stepBuilders.get("capitalizeNamesStep").<Person, Person>chunk(10)
         .reader(multiItemReader()).processor(itemProcessor()).writer(itemWriter()).build();
   }
 
   @Bean
-  public Step deleteFilesStep() {
+  public Step deleteFilesStep(StepBuilderFactory stepBuilders) {
     return stepBuilders.get("deleteFilesStep").tasklet(fileDeletingTasklet()).build();
   }