Skip to content

Commit e5aec23

Browse files
bborehamsrijan55
authored andcommitted
Update go-kit/kit to 0.12.0 to fix spurious debug logs (cortexproject#4544)
* Update go-kit/kit to 0.12.0 to fix spurious debug logs This version of go-kit/kit/log is just a pass-through to go-kit/log. (Note pinned aws-sdk to previous version) Also updates the following: * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf Also: * compactor unit tests: make log messages consistent Apparently updating go-kit has made our log lines more consistent Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
1 parent 4ff17cf commit e5aec23

File tree

186 files changed

+3548
-10938
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

186 files changed

+3548
-10938
lines changed

go.mod

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,15 @@ require (
1111
github.com/NYTimes/gziphandler v1.1.1
1212
github.com/alecthomas/units v0.0.0-20210912230133-d1bdfacee922
1313
github.com/alicebob/miniredis/v2 v2.14.3
14-
github.com/aws/aws-sdk-go v1.40.37
14+
github.com/aws/aws-sdk-go v1.40.45
1515
github.com/bradfitz/gomemcache v0.0.0-20190913173617-a41fca850d0b
1616
github.com/cespare/xxhash v1.1.0
1717
github.com/dustin/go-humanize v1.0.0
1818
github.com/facette/natsort v0.0.0-20181210072756-2cd4dd1e2dcb
1919
github.com/felixge/fgprof v0.9.1
2020
github.com/fsouza/fake-gcs-server v1.7.0
21-
github.com/go-kit/log v0.1.0
21+
github.com/go-kit/kit v0.12.0 // indirect
22+
github.com/go-kit/log v0.2.0
2223
github.com/go-openapi/strfmt v0.20.2
2324
github.com/go-openapi/swag v0.19.15
2425
github.com/go-redis/redis/v8 v8.11.4
@@ -30,7 +31,7 @@ require (
3031
github.com/golang/snappy v0.0.4
3132
github.com/gorilla/mux v1.8.0
3233
github.com/grafana/dskit v0.0.0-20211021180445-3bd016e9d7f1
33-
github.com/json-iterator/go v1.1.11
34+
github.com/json-iterator/go v1.1.12
3435
github.com/lib/pq v1.3.0
3536
github.com/minio/minio-go/v7 v7.0.10
3637
github.com/mitchellh/go-wordwrap v1.0.0
@@ -54,7 +55,7 @@ require (
5455
github.com/weaveworks/common v0.0.0-20210913144402-035033b78a78
5556
go.etcd.io/bbolt v1.3.6
5657
go.uber.org/atomic v1.9.0
57-
golang.org/x/net v0.0.0-20210903162142-ad29c8ab022f
58+
golang.org/x/net v0.0.0-20210917221730-978cfadd31cf
5859
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
5960
golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac
6061
google.golang.org/api v0.56.0
@@ -85,3 +86,7 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.38.0
8586
// confused about which version is the latest one. v0.22.0 was released in July, but latest tag reachable from main
8687
// is v0.19.1. We pin version from late september here. Feel free to remove when updating to later version.
8788
replace github.com/thanos-io/thanos v0.22.0 => github.com/thanos-io/thanos v0.19.1-0.20210923155558-c15594a03c45
89+
90+
// Pin aws-sdk to version prior to go-kit update, to reduce the bulk of change.
91+
// Un-pin once Cortex 1.11 is released.
92+
replace github.com/aws/aws-sdk-go => github.com/aws/aws-sdk-go v1.40.37

go.sum

Lines changed: 61 additions & 46 deletions
Large diffs are not rendered by default.

pkg/compactor/compactor_test.go

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -510,16 +510,16 @@ func TestCompactor_ShouldIterateOverUsersAndRunCompaction(t *testing.T) {
510510
`level=info component=compactor msg="discovering users from bucket"`,
511511
`level=info component=compactor msg="discovered users from bucket" users=2`,
512512
`level=info component=compactor msg="starting compaction of user blocks" user=user-1`,
513-
`component=compactor org_id=user-1 level=info msg="start sync of metas"`,
514-
`component=compactor org_id=user-1 level=info msg="start of GC"`,
515-
`component=compactor org_id=user-1 level=info msg="start of compactions"`,
516-
`component=compactor org_id=user-1 level=info msg="compaction iterations done"`,
513+
`level=info component=compactor org_id=user-1 msg="start sync of metas"`,
514+
`level=info component=compactor org_id=user-1 msg="start of GC"`,
515+
`level=info component=compactor org_id=user-1 msg="start of compactions"`,
516+
`level=info component=compactor org_id=user-1 msg="compaction iterations done"`,
517517
`level=info component=compactor msg="successfully compacted user blocks" user=user-1`,
518518
`level=info component=compactor msg="starting compaction of user blocks" user=user-2`,
519-
`component=compactor org_id=user-2 level=info msg="start sync of metas"`,
520-
`component=compactor org_id=user-2 level=info msg="start of GC"`,
521-
`component=compactor org_id=user-2 level=info msg="start of compactions"`,
522-
`component=compactor org_id=user-2 level=info msg="compaction iterations done"`,
519+
`level=info component=compactor org_id=user-2 msg="start sync of metas"`,
520+
`level=info component=compactor org_id=user-2 msg="start of GC"`,
521+
`level=info component=compactor org_id=user-2 msg="start of compactions"`,
522+
`level=info component=compactor org_id=user-2 msg="compaction iterations done"`,
523523
`level=info component=compactor msg="successfully compacted user blocks" user=user-2`,
524524
}, removeIgnoredLogs(strings.Split(strings.TrimSpace(logs.String()), "\n")))
525525

@@ -626,18 +626,18 @@ func TestCompactor_ShouldNotCompactBlocksMarkedForDeletion(t *testing.T) {
626626
assert.ElementsMatch(t, []string{
627627
`level=info component=cleaner msg="started blocks cleanup and maintenance"`,
628628
`level=info component=cleaner org_id=user-1 msg="started blocks cleanup and maintenance"`,
629-
`component=cleaner org_id=user-1 level=debug msg="deleted file" file=01DTW0ZCPDDNV4BV83Q2SV4QAZ/meta.json bucket=mock`,
630-
`component=cleaner org_id=user-1 level=debug msg="deleted file" file=01DTW0ZCPDDNV4BV83Q2SV4QAZ/deletion-mark.json bucket=mock`,
629+
`level=debug component=cleaner org_id=user-1 msg="deleted file" file=01DTW0ZCPDDNV4BV83Q2SV4QAZ/meta.json bucket=mock`,
630+
`level=debug component=cleaner org_id=user-1 msg="deleted file" file=01DTW0ZCPDDNV4BV83Q2SV4QAZ/deletion-mark.json bucket=mock`,
631631
`level=info component=cleaner org_id=user-1 msg="deleted block marked for deletion" block=01DTW0ZCPDDNV4BV83Q2SV4QAZ`,
632632
`level=info component=cleaner org_id=user-1 msg="completed blocks cleanup and maintenance"`,
633633
`level=info component=cleaner msg="successfully completed blocks cleanup and maintenance"`,
634634
`level=info component=compactor msg="discovering users from bucket"`,
635635
`level=info component=compactor msg="discovered users from bucket" users=1`,
636636
`level=info component=compactor msg="starting compaction of user blocks" user=user-1`,
637-
`component=compactor org_id=user-1 level=info msg="start sync of metas"`,
638-
`component=compactor org_id=user-1 level=info msg="start of GC"`,
639-
`component=compactor org_id=user-1 level=info msg="start of compactions"`,
640-
`component=compactor org_id=user-1 level=info msg="compaction iterations done"`,
637+
`level=info component=compactor org_id=user-1 msg="start sync of metas"`,
638+
`level=info component=compactor org_id=user-1 msg="start of GC"`,
639+
`level=info component=compactor org_id=user-1 msg="start of compactions"`,
640+
`level=info component=compactor org_id=user-1 msg="compaction iterations done"`,
641641
`level=info component=compactor msg="successfully compacted user blocks" user=user-1`,
642642
}, removeIgnoredLogs(strings.Split(strings.TrimSpace(logs.String()), "\n")))
643643

@@ -734,8 +734,8 @@ func TestCompactor_ShouldNotCompactBlocksForUsersMarkedForDeletion(t *testing.T)
734734
assert.ElementsMatch(t, []string{
735735
`level=info component=cleaner msg="started blocks cleanup and maintenance"`,
736736
`level=info component=cleaner org_id=user-1 msg="deleting blocks for tenant marked for deletion"`,
737-
`component=cleaner org_id=user-1 level=debug msg="deleted file" file=01DTVP434PA9VFXSW2JKB3392D/meta.json bucket=mock`,
738-
`component=cleaner org_id=user-1 level=debug msg="deleted file" file=01DTVP434PA9VFXSW2JKB3392D/index bucket=mock`,
737+
`level=debug component=cleaner org_id=user-1 msg="deleted file" file=01DTVP434PA9VFXSW2JKB3392D/meta.json bucket=mock`,
738+
`level=debug component=cleaner org_id=user-1 msg="deleted file" file=01DTVP434PA9VFXSW2JKB3392D/index bucket=mock`,
739739
`level=info component=cleaner org_id=user-1 msg="deleted block" block=01DTVP434PA9VFXSW2JKB3392D`,
740740
`level=info component=cleaner org_id=user-1 msg="deleted blocks for tenant marked for deletion" deletedBlocks=1`,
741741
`level=info component=cleaner org_id=user-1 msg="updating finished time in tenant deletion mark"`,
@@ -855,16 +855,16 @@ func TestCompactor_ShouldCompactAllUsersOnShardingEnabledButOnlyOneInstanceRunni
855855
`level=info component=compactor msg="discovering users from bucket"`,
856856
`level=info component=compactor msg="discovered users from bucket" users=2`,
857857
`level=info component=compactor msg="starting compaction of user blocks" user=user-1`,
858-
`component=compactor org_id=user-1 level=info msg="start sync of metas"`,
859-
`component=compactor org_id=user-1 level=info msg="start of GC"`,
860-
`component=compactor org_id=user-1 level=info msg="start of compactions"`,
861-
`component=compactor org_id=user-1 level=info msg="compaction iterations done"`,
858+
`level=info component=compactor org_id=user-1 msg="start sync of metas"`,
859+
`level=info component=compactor org_id=user-1 msg="start of GC"`,
860+
`level=info component=compactor org_id=user-1 msg="start of compactions"`,
861+
`level=info component=compactor org_id=user-1 msg="compaction iterations done"`,
862862
`level=info component=compactor msg="successfully compacted user blocks" user=user-1`,
863863
`level=info component=compactor msg="starting compaction of user blocks" user=user-2`,
864-
`component=compactor org_id=user-2 level=info msg="start sync of metas"`,
865-
`component=compactor org_id=user-2 level=info msg="start of GC"`,
866-
`component=compactor org_id=user-2 level=info msg="start of compactions"`,
867-
`component=compactor org_id=user-2 level=info msg="compaction iterations done"`,
864+
`level=info component=compactor org_id=user-2 msg="start sync of metas"`,
865+
`level=info component=compactor org_id=user-2 msg="start of GC"`,
866+
`level=info component=compactor org_id=user-2 msg="start of compactions"`,
867+
`level=info component=compactor org_id=user-2 msg="compaction iterations done"`,
868868
`level=info component=compactor msg="successfully compacted user blocks" user=user-2`,
869869
}, removeIgnoredLogs(strings.Split(strings.TrimSpace(logs.String()), "\n")))
870870
}

vendor/github.com/armon/go-metrics/inmem.go

Lines changed: 24 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/armon/go-metrics/inmem_endpoint.go

Lines changed: 32 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/armon/go-metrics/prometheus/prometheus.go

Lines changed: 16 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)