sql/*: implement drop index statement #183
Conversation
|
could you rebase this one too @erizocosmico ? |
|
Sure |
erizocosmico
force-pushed
the
feature/drop-index
branch
from
29e42e2 to
cadc0e1
Compare
|
Fixed @ajnavarro |
sql/index.go
Outdated
| @@ -206,6 +209,8 @@ func (r *IndexRegistry) ReleaseIndex(idx Index) { | |||
| func (r *IndexRegistry) Index(db, id string) Index { | |||
| r.mut.RLock() | |||
| defer r.mut.RUnlock() | |||
| r.retainIndex(db, id) | |||
| fmt.Println(indexKey{db, strings.ToLower(id)}) | |||
sql/plan/drop_index.go
Outdated
| return nil, ErrInvalidIndexDriver.New(index.Driver()) | ||
| } | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
should we block until the index is deleted?
There was a problem hiding this comment.
It depends. Do we want to make the user wait until it's deleted or succeed and asynchronously delete the index?
There was a problem hiding this comment.
on index deletion (that shouldn't take A LOT) I think we should wait until the index is dropped, or throw an error otherwise. WDYT @kuba-- ?
There was a problem hiding this comment.
delete index is/should be super fast (basically it deletes directory). so far it also sends delete to pilosa synchronously (because i didn't notice any lag), but If we encounter any issues we can async. call pilosa). Just to recap, it's totally fine to delete just directory. Pilosa bitmap can be deleted any time or even overwritten.
There was a problem hiding this comment.
yeah, lets block and wait if we get an error
There was a problem hiding this comment.
yeah, lets block and wait if we get an error
erizocosmico
force-pushed
the
feature/drop-index
branch
2 times, most recently
from
fb811d8 to
a1ee88e
Compare
|
Done @ajnavarro @kuba-- |
erizocosmico
force-pushed
the
feature/drop-index
branch
from
a1ee88e to
c82ee66
Compare
|
Rebased. Any else left so we can merge this, @kuba--? |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
LGTM |
Depends on #182
Closes #172