Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Commit 2f2b1cd

Browse files
committed
Fixed tautological error conditions
Removed err handling where err's value can't possibly have changed. Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com>
1 parent c363771 commit 2f2b1cd

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

plumbing/format/commitgraph/encoder.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ func (e *Encoder) Encode(idx Index) error {
5656
return err
5757
}
5858
}
59-
if err != nil {
60-
return err
61-
}
6259
return e.encodeChecksum()
6360
}
6461

plumbing/transport/server/server.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,6 @@ func (s *rpSession) updateReferences(req *packp.ReferenceUpdateRequest) {
286286
continue
287287
}
288288

289-
if err != nil {
290-
s.setStatus(cmd.Name, err)
291-
continue
292-
}
293-
294289
ref := plumbing.NewHashReference(cmd.Name, cmd.New)
295290
err := s.storer.SetReference(ref)
296291
s.setStatus(cmd.Name, err)

remote.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -906,7 +906,7 @@ func (r *Remote) updateLocalReferenceStorage(
906906
updated = true
907907
}
908908

909-
if err == nil && forceNeeded {
909+
if forceNeeded {
910910
err = ErrForceNeeded
911911
}
912912

0 commit comments

Comments
 (0)