Skip to content

Update go-mysql-server and prepare changelog for the next rc version #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

Update go-mysql-server and prepare changelog for the next rc version #964

merged 1 commit into from
Oct 2, 2019

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Oct 2, 2019 •
edited
Loading

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.

@ajnavarro ajnavarro requested a review from a team October 2, 2019 09:15
@ajnavarro ajnavarro force-pushed the update-go-mysql-server-021019 branch from 9c7d157 to a83babc Compare October 2, 2019 09:16
agarciamontoro
agarciamontoro approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: why does the go-mysql-server version in go.mod still has the v0.4.1 prefix? I don't understand why it is not v0.5.1.

@ajnavarro ajnavarro changed the title Update go-mysql-server Update go-mysql-server and prepare changelog for the next rc version Oct 2, 2019
@erizocosmico
Copy link
Contributor

@agarciamontoro because go modules use minimal version selection

carlosms
carlosms reviewed Oct 2, 2019
View reviewed changes
@ajnavarro ajnavarro requested a review from carlosms October 2, 2019 16:14
@ajnavarro
Update go-mysql-server
e155187 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the update-go-mysql-server-021019 branch from a83babc to e155187 Compare October 2, 2019 16:15
@ajnavarro ajnavarro merged commit 97d9667 into src-d:master Oct 2, 2019
@ajnavarro ajnavarro deleted the update-go-mysql-server-021019 branch October 2, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanjux juanjux juanjux approved these changes

@erizocosmico erizocosmico erizocosmico approved these changes

@agarciamontoro agarciamontoro agarciamontoro approved these changes

@carlosms carlosms Awaiting requested review from carlosms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajnavarro @erizocosmico @juanjux @carlosms @agarciamontoro