Adds possibility to configure conn max lifetime #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
dpordomingo
approved these changes
Jan 24, 2019
carlosms
reviewed
Jan 24, 2019
Contributor
Author
carlosms
approved these changes
Jan 24, 2019
Contributor
carlosms
left a comment
carlosms
left a comment
There was a problem hiding this comment.
👍 but the DCO check fails when applying suggestions from github. Please squash/whatever before merging.
Contributor
Author
|
Yup I was waiting for your approvals before squashing and fixing DCO. Gonna do it and merge 👍 |
Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
se7entyse7en
force-pushed
the
configurable-conn-max-lifetime
branch
from
067c796 to
d0e8c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262.