Skip to content

Adds possibility to configure conn max lifetime #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

se7entyse7en
Copy link
Contributor

Closes #262.

Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
@se7entyse7en se7entyse7en requested a review from a team January 23, 2019 18:26
@se7entyse7en
Copy link
Contributor Author

@carlosms I applied your suggestion 067c796

Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but the DCO check fails when applying suggestions from github. Please squash/whatever before merging.

@se7entyse7en
Copy link
Contributor Author

Yup I was waiting for your approvals before squashing and fixing DCO. Gonna do it and merge 👍

Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
@se7entyse7en se7entyse7en force-pushed the configurable-conn-max-lifetime branch from 067c796 to d0e8c75 Compare January 25, 2019 00:25
@se7entyse7en se7entyse7en merged commit 6dcbed5 into src-d:master Jan 25, 2019
@se7entyse7en se7entyse7en deleted the configurable-conn-max-lifetime branch January 25, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants