UAST viewer does not render nodes when UAST arg is a string

[carlosms]

For the following query:

select 'console.log("hello world");
console.log("bye");' as code, UAST('console.log("hello world");
console.log("bye");', 'javascript') as uast

The UAST button opens a panel where the body Nodes cannot be expanded. Clicking on + does nothing.

[smacker]

Just a note: it must be gitbase-web bug not the uast-viewer itself.
Because console.log("hello world");\nconsole.log("bye"); is displayed correctly on bblfsh playground.

[se7entyse7en]

This is issue affects also non-string argument to UAST but is much extensive. It can be replicated also with the Files named main.go example and affects also other types of elements such as Doc and Path.

[se7entyse7en]

The expansion of the node works well in the code viewer modal, but doesn't in the uast viewer one. By using the react dev tool on chrome, I noticed that the props onNode{Click,Hover,Toggle} are not passed in the FlatUASTViewer used in the uast viewer modal.

I found that these props are passed here when using the withUASTEditor, and if I understand correctly these are the props that make the collapsible nodes work.

IMHO the behavior that we have in the code viewer given by the aforementioned props could be the default. I mean that I don't see the need for customizing them. What I'd do is to move those handlers into FlatUASTViewer and to change the onNode{Click,Hover,Toggle} into enableNode{Click,Hover,Toggle}. So that for example for the uast viewer we may want to disable hover.

WDYT?

[smacker]

discussed in slack. Marvin missed the fact that uast-viewer uses default handlers when it's used like this <UASTViewer initialUast={uast} /> and doesn't need passing any props manually.