switch back to the original error_reporting level #488
Conversation
| @@ -188,12 +188,13 @@ protected function printFooter() | |||
| { | |||
| // Turn off errors so we don't get timezone warnings if people | |||
| // don't have their timezone set. | |||
| $errorLevel = error_reporting(); | |||
| error_reporting(0); | |||
There was a problem hiding this comment.
Just do $errorLevel = error_reporting(0); instead of adding extra line because error_reportring function, if I'm not mistaken always returns previous error level.
There was a problem hiding this comment.
you are right i have changed this
|
👍 , I wonder how you're able to find this place. The only reason would be, when PHP_CodeSniffer's PHP files are included in other project that had some errors in it. |
|
If you include CLI.php to actually run PHPCS, error reporting is set for you. CLI is required for any sort of checking or reporting functionality, so it would be pretty hard to get the error reporting level set to anything other than But I'll still merge the code in because it wont break anything. I assume PHP_CodeSniffer must be being used in a different way in this case, causing a problem. |
switch back to the original error_reporting level
…e-after-cast Generic/SpaceAfterCast: improve code coverage
Instate of switching to a high error reporting level switch back to last error reporting level