PHPCS 4.x: let T_STATIC be T_STATIC
#3121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/3115-let-static-be-static
branch
from
13311ae
to
c644756
Compare
|
Rebased for imaginary merge conflict. |
jrfnl
force-pushed
the
feature/3115-let-static-be-static
branch
from
c644756
to
b113d5d
Compare
|
Rebased for merge conflict. |
jrfnl
force-pushed
the
feature/3115-let-static-be-static
branch
3 times, most recently
from
268e2a8
to
2f97842
Compare
Implementation of the proposal outlined in issue 3115. 1. Removes the Tokenizer/PHP code which made an exception for `instanceof static`. 2. Adds an exception for `instanceof static` to the `Squiz.WhiteSpace.ScopeKeywordSpacing` sniff for which the tokenizer code was originally put in place. The tests for all other sniffs still pass. I've had a quick look through the other sniffs which refer to the `T_STATIC` token, but didn't see any which should be impacted by this change (and didn't have unit tests with `instanceof static`). Fixes 3115
jrfnl
force-pushed
the
feature/3115-let-static-be-static
branch
from
2f97842
to
4d1bc03
Compare
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the proposal outlined in issue #3115.
instanceof static.instanceof staticto theSquiz.WhiteSpace.ScopeKeywordSpacingsniff for which the tokenizer code was originally put in place.The tests for all other sniffs still pass.
I've had a quick look through the other sniffs which refer to the
T_STATICtoken, but didn't see any which should be impacted by this change (and didn't have unit tests withinstanceof static).Fixes #3115