Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow checking assignment operators #2515

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Add option to allow checking assignment operators #2515

merged 1 commit into from
Aug 8, 2019

Conversation

grongor
Copy link
Contributor

@grongor grongor commented May 22, 2019

I would like to enforce checking of spaces around assignments as I'm not allowing statements alignment. This simple change (no BC-break) allows me to do so.

@gsherwood
Copy link
Member

I like this idea.

I think the public var should be renamed - maybe to ignoreSpacingBeforeAssignments - to keep it consistent. It would then be TRUE by default.

@gsherwood gsherwood added this to the 3.5.0 milestone Jun 24, 2019
@gsherwood gsherwood merged commit e1aaf39 into squizlabs:master Aug 8, 2019
gsherwood added a commit that referenced this pull request Aug 8, 2019
@gsherwood
Copy link
Member

Thanks for the PR. I ended up changing the name of the sniff property and have documented it here: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizwhitespaceoperatorspacing

afilina pushed a commit to afilina/PHP_CodeSniffer that referenced this pull request Oct 1, 2020
afilina pushed a commit to afilina/PHP_CodeSniffer that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants